High availability & sentinel #101

Cylix · 2017-08-25T05:50:25Z

Cpp Redis changes in order to implement the Redis high availability and sentinel features.
This will need some time to code review everything, port windows changes to unix and test it.

Full credits to Mike Moeining for his amazing work!

…iber which will handle connect/reconnection automatically to redis server.

… changes to unix.

Cylix · 2017-08-26T02:29:58Z

includes/cpp_redis/network/redis_connection.hpp

 //! ctor & dtor
 #ifndef __CPP_REDIS_USE_CUSTOM_TCP_CLIENT
-  redis_connection(void);
+  redis_connection(std::uint32_t num_io_workers = 2);


need to be ported to future_client too

Cylix · 2017-08-26T02:38:44Z

includes/cpp_redis/redis_client.hpp

  typedef std::function<void(reply&)> reply_callback_t;
  redis_client& set_callback_runner(const std::function<void(reply&, const reply_callback_t& callback)>& callback);
-  redis_client& send(const std::vector<std::string>& redis_cmd, const reply_callback_t& callback = nullptr);
+  virtual redis_client& send(const std::vector<std::string>& redis_cmd, const reply_callback_t& callback = nullptr);


double check that

Cylix · 2017-08-26T02:39:23Z

includes/cpp_redis/redis_subscriber.hpp

 namespace cpp_redis {

 class redis_subscriber {
+  friend class ha_redis_subscriber;


double check that, kind of dislike use of friend. Is it necessary?

Cylix · 2017-08-26T02:39:39Z

includes/cpp_redis/redis_subscriber.hpp

-  void connect(const std::string& host = "127.0.0.1", std::size_t port = 6379, const disconnection_handler_t& disconnection_handler = nullptr);
-  void disconnect(bool wait_for_removal = false);
-  bool is_connected(void);
+  virtual void connect(const std::string& host = "127.0.0.1", std::size_t port = 6379, const disconnection_handler_t& disconnection_handler = nullptr, std::uint32_t timeout_msecs = 0);


check uses of virtual

Cylix · 2017-08-26T02:39:56Z

install_deps.sh

@@ -0,0 +1,12 @@
+#!/bin/sh


should be removed

MikesAracade · 2017-08-26T02:41:27Z

Go ahead. I’m not sure what that is… Mike Moening *From:* Simon Ninon [mailto:notifications@github.com] *Sent:* Friday, August 25, 2017 9:40 PM *To:* Cylix/cpp_redis *Cc:* Subscribed *Subject:* Re: [Cylix/cpp_redis] High availability & sentinel (#101) *@Cylix* commented on this pull request. ------------------------------ In install_deps.sh <#101 (comment)>:

@@ -0,0 +1,12 @@

+#!/bin/sh should be removed — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#101 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARc77Gr3HIsmeUgzez5T0-rigKw7Q_0gks5sb4V-gaJpZM4PCQHc> .[image: Image removed by sender.]

Cylix · 2017-08-26T02:41:40Z

sources/redis_client.cpp


+redis_client&
+redis_client::scan(int cursor, const std::string& pattern, int count, const reply_callback_t& reply_callback) {
+  if (pattern.size() > 0) {


MikesAracade · 2017-08-26T02:42:01Z

Try taking it out and compiling. Then you will see why… Mike Moening *From:* Simon Ninon [mailto:notifications@github.com] *Sent:* Friday, August 25, 2017 9:39 PM *To:* Cylix/cpp_redis *Cc:* Subscribed *Subject:* Re: [Cylix/cpp_redis] High availability & sentinel (#101) *@Cylix* commented on this pull request. ------------------------------ In includes/cpp_redis/redis_subscriber.hpp <#101 (comment)>:

@@ -33,10 +33,12 @@

namespace cpp_redis { class redis_subscriber { + friend class ha_redis_subscriber; double check that, kind of dislike use of friend. Is it necessary? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#101 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARc77GiBkVTeohfTTA5ELKAXgEkoT2Iuks5sb4VdgaJpZM4PCQHc> .[image: Image removed by sender.]

Cylix · 2017-08-26T02:42:17Z

tests/sources/spec/redis_subscriber_spec.cpp

 #include <cpp_redis/redis_client.hpp>
 #include <cpp_redis/redis_error.hpp>
 #include <cpp_redis/redis_subscriber.hpp>
-


should not be changed

Cylix · 2017-08-26T02:42:23Z

tests/sources/spec/redis_client_spec.cpp


 #include <cpp_redis/redis_client.hpp>
 #include <cpp_redis/redis_error.hpp>
-


should not be changed

MikesAracade · 2017-08-26T02:56:23Z

The virtual is necessary since we are overriding the base classes connect. We also want to allow this class to potentially be overridden as well by another down the road. Mike Moening *From:* Simon Ninon [mailto:notifications@github.com] *Sent:* Friday, August 25, 2017 9:40 PM *To:* Cylix/cpp_redis *Cc:* Subscribed *Subject:* Re: [Cylix/cpp_redis] High availability & sentinel (#101) *@Cylix* commented on this pull request. ------------------------------ In includes/cpp_redis/redis_subscriber.hpp <#101 (comment)>:

@@ -48,15 +50,15 @@ class redis_subscriber {

public: //! handle connection typedef std::function<void(redis_subscriber&)> disconnection_handler_t; - void connect(const std::string& host = "127.0.0.1", std::size_t port = 6379, const disconnection_handler_t& disconnection_handler = nullptr); - void disconnect(bool wait_for_removal = false); - bool is_connected(void); + virtual void connect(const std::string& host = "127.0.0.1", std::size_t port = 6379, const disconnection_handler_t& disconnection_handler = nullptr, std::uint32_t timeout_msecs = 0); check uses of virtual — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#101 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARc77IHK2SNjcfZnWd678uSoNADW9EMZks5sb4V6gaJpZM4PCQHc> .[image: Image removed by sender.]

…ke interface cleaner. rename redis_ prefix to classes

…e with callbacks execution)

Cylix · 2017-09-20T18:50:10Z

This PR is now successfully reworked!

Considering the initial changes, here are the main changes:

ha_client is merged into client such that high availability can be used by any client easily.
ha_subscriber is merged into subscriber for the same reasons.
some small bugs have been fixed
client dont take number of io service workers as a parameter. Instead, io service num worker can be set from tcp_client or globally thanks to a dedicated function

Some other big changes not related to the original changes have been also brought and are listed in the CHANGELOG.

This will be released under 4.0.0.
I changed the base branch to be v4.x.x to temporarily hold the release on that branch the time to update the wiki doc, then it will be definitely merged onto master.

Please let me know if you have any feedbacks :)

Thanks again for your great work, it has been really inspiring and I believe it is a really meaningful and useful contribution to cpp_redis! So thanks a lot Mike, I really appreciate your constant involvement in this library!

Best :)

* High availability, sentinel, design improvement (#101) * Added sentiel and high availability(HA) versions of client and subscriber which will handle connect/reconnection automatically to redis server. * Merged changes * clang format * bump tacopie * unix compilation. will need some time to code review and port windows changes to unix. * clean unecessary changes. merge future_client into redis_client to make interface cleaner. rename redis_ prefix to classes * merge ha_client into client, refactore architecture. * merge ha_subscriber into subscriber * try_commit instead of commit in disconnection flow * doxygen * tacopie link & documentation & compilation fix * fix reconnection process * fix unit tests * clean code sentinel & make it consistent (avoid regression for example with callbacks execution) * ability to change number of io service workers at runtime * ha redis client example * doxygen doc * switch ZADD score param from map to multimap #107 * update CHANGELOG.md for 4.0.0 release * bump tacopie * [4.0.0] update README

MikesAracade and others added 6 commits August 14, 2017 14:37

Added sentiel and high availability(HA) versions of client and subscr…

d7fbff5

…iber which will handle connect/reconnection automatically to redis server.

Added sentiel and high availability(HA) versions of client and subscr…

cc444a7

…iber which will handle connect/reconnection automatically to redis server.

Merged changes

f888586

clang format

9b9bf10

bump tacopie

8184ec6

unix compilation. will need some time to code review and port windows…

fcafd93

… changes to unix.

Cylix added the enhancement label Aug 25, 2017

merge master

775bfe1

Cylix commented Aug 26, 2017

View reviewed changes

install_deps.sh Outdated

@@ -0,0 +1,12 @@

#!/bin/sh

Copy link

Owner Author

Cylix Aug 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed

Cylix commented Aug 26, 2017

View reviewed changes

clean unecessary changes. merge future_client into redis_client to ma…

abdc77a

…ke interface cleaner. rename redis_ prefix to classes

Cylix mentioned this pull request Sep 8, 2017

commit in example seems redundant #106

Closed

Simon Ninon and others added 9 commits September 12, 2017 19:09

merge ha_client into client, refactore architecture.

305f081

merge ha_subscriber into subscriber

e13ebea

try_commit instead of commit in disconnection flow

635fe9a

doxygen

d3426bb

tacopie link & documentation & compilation fix

4ee7ff2

fix reconnection process

741e9b3

fix unit tests

7eafe7d

clean code sentinel & make it consistent (avoid regression for exampl…

200ab3e

…e with callbacks execution)

ability to change number of io service workers at runtime

81e6658

Cylix added 5 commits September 18, 2017 21:44

ha redis client example

ccca34e

doxygen doc

4a40a2e

switch ZADD score param from map to multimap #107

92528bc

update CHANGELOG.md for 4.0.0 release

b3a4d0e

bump tacopie

1eb6db3

Cylix changed the base branch from master to v4.x.x September 20, 2017 18:43

Cylix merged commit f0a3dba into v4.x.x Sep 20, 2017

Cylix deleted the high-availability-&-sentinel branch September 20, 2017 18:51

Cylix mentioned this pull request Sep 20, 2017

Cpp redis sentinel Cylix/tacopie#19

Merged


		#include <cpp_redis/redis_client.hpp>
		#include <cpp_redis/redis_error.hpp>

High availability & sentinel #101

High availability & sentinel #101

Uh oh!

Conversation

Cylix commented Aug 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MikesAracade commented Aug 26, 2017 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MikesAracade commented Aug 26, 2017 via email

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MikesAracade commented Aug 26, 2017 via email

Uh oh!

Cylix commented Sep 20, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants